deps(keyring-controller): ethereumjs-wallet@^1.0.1 -> @ethereumjs/wallet@^2.0.4

[legobeat]

Explanation

Removes dependency on legacy and deprecated ethereumjs-wallet.

References

Related

• fix: upgrade from ethereumjs-util to @ethereumjs/util metamask-extension#28169

Blocked by

• Bump min Node version to 18.18; use LTS for dev #3611

Changelog

@metamask/keyring-controller

• CHANGED: Update from ethereumjs-wallet@^1.0.1 to @ethereumjs/wallet@^2.0.4

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@ethereumjs/[email protected]	Transitive: network	+3	1.11 MB	holgerd77

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/@ethereumjs/[email protected]	Module: globalThis["fetch"] Location: Package overview	packages/keyring-controller/package.json	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/@ethereumjs/[email protected]

[legobeat]

@SocketSecurity ignore npm/@ethereumjs/[email protected]

network access ok

[legobeat]

@MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers: I believe DO-NOT-MERGE label can be removed.