-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CAIP Multichain (New) #27782
base: caip25-permission-migration
Are you sure you want to change the base?
feat: CAIP Multichain (New) #27782
Conversation
# Conflicts: # lavamoat/browserify/beta/policy.json # lavamoat/browserify/flask/policy.json # lavamoat/browserify/main/policy.json # lavamoat/browserify/mmi/policy.json
…' into caip-multichain
This reverts commit d46d3bb.
This reverts commit bbbf8e5.
# Conflicts: # lavamoat/browserify/beta/policy.json # lavamoat/browserify/flask/policy.json # lavamoat/browserify/main/policy.json # lavamoat/browserify/mmi/policy.json
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Misc cleanup. Removing `KnownCaipNamespace` is still not possible because `@metamask/util` does not have a `Wallet` enum value [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26724?quickstart=1) ## **Related issues** See: MetaMask/MetaMask-planning#3050 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** * Add metrics to `provider_authorize` * Add jsdoc to `removeScope()` [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26699?quickstart=1) ## **Related issues** See: MetaMask/MetaMask-planning#3049 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Test cleanup chores [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26698?quickstart=1) ## **Related issues** See: MetaMask/MetaMask-planning#3046 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
… into jl/caip-multichain-migrate-core
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [3222176]
Page Load Metrics (1689 ± 129 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3222176]
Page Load Metrics (1789 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [6662dd3]
Page Load Metrics (1821 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Object.entries(this.connections[origin]).forEach( | ||
([_, { tabId }]) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object.entries(this.connections[origin]).forEach( | |
([_, { tabId }]) => { | |
Object.values(this.connections[origin]).forEach( | |
({ tabId }) => { |
seems like Object.entries
is not necessary here since you are only using the value inside the loop and never the _
key.
… into jl/caip-multichain-migrate-core
… into jl/caip-multichain-migrate-core
939d897
to
069a8a7
Compare
Builds ready [0048c4d]
Page Load Metrics (1586 ± 49 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [f478911]
Page Load Metrics (1537 ± 31 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This branch is the feature branch for CAIP-25, CAIP-27, CAIP stream bifurcation. TODO better PR desc.
Related issues
Related: MetaMask/core#4813
Upstream: #27847
See: https://github.com/MetaMask/MetaMask-planning/issues/2360
See: MetaMask/test-dapp#324
Manual testing steps
Replace EXTENSION_ID with your local extension ID
Locked Wallet Behavior
wallet_getSession
returns full session with all accountswallet_revokeSession
works as usualwallet_createSession
prompts for unlockwallet_invokeMethod
on signature methods fails with method or accounts not authorizedwallet_invokeMethod
on non-signature methods work as usualwallet_sessionChanged
not being fired when locked and revokeSession is called (TODO need to fix this). Is being fired when unlocked and revokeSession is called.Wallet Onboarding Behavior (fresh install, not setup yet)
wallet_createSession
causes wallet setup screen to be shown insteadwallet_getSession
returns no session since there is nonewallet_invokeMethod
fails for everything since there is no active sessionScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist