chore: change default network avatar style #28976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [1eb299c]
Page Load Metrics (2058 ± 49 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7b5b184]
Page Load Metrics (2004 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
7 tasks
Builds ready [cf1d1e8]
Page Load Metrics (2135 ± 98 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0d0fbbe]
Page Load Metrics (2233 ± 55 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
force-pushed
the
mb894-network-design-updates
branch
from
0d0fbbe to
f62f604
Compare
Builds ready [f62f604]
Page Load Metrics (2288 ± 94 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
7 tasks
There was a problem hiding this comment.
This is looking great! I’ve tried to check most instances of BadgeWrapper that don’t use AvatarNetwork to ensure that the changes to the defaults haven’t been overridden for those use cases, and so far, so good. I left one small question about the border color in the CSS; otherwise, I think it’s good to go.
I’d also like to understand how this change will be rolled out or planned for mobile and the portfolio. Ideally, they should be released at the same time or very close together to avoid inconsistencies across platforms.
ui/components/component-library/avatar-network/avatar-network.scss
Outdated
Show resolved
Hide resolved
ui/components/component-library/avatar-network/avatar-network.scss
Outdated
Show resolved
Hide resolved
ui/components/component-library/avatar-network/avatar-network.scss
Outdated
Show resolved
Hide resolved
| @@ -52,6 +53,8 @@ export const AvatarNetwork: AvatarNetworkComponent = React.forwardRef( | |||
| showHalo ? 'mm-avatar-network--with-halo' : '', | |||
| className, | |||
| )} | |||
| borderRadius={BorderRadius.MD} | |||
| borderWidth={1} | |||
There was a problem hiding this comment.
non-blocking: Because of how borders work in the DOM, adding this will effectively reduce the size of the AvatarNetwork by 2px since the border will be included within the avatar size. I believe this has been adjusted in a few places, so it might not be an issue. However, we might need to account for this by applying box-sizing: content-box.
box-sizing.720.mov
There was a problem hiding this comment.
Good callout. The designs actually call for including the border within the avatar's size so I have removed the content-box sizing from the AvatarNetwork
micaelae
force-pushed
the
mb894-network-design-updates
branch
from
f62f604 to
06226c7
Compare
Builds ready [06226c7]
Page Load Metrics (1938 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
georgewrmarshall
approved these changes
Dec 11, 2024
|
I noticed some AvatarNetwork instances that need to be shifted to the bottom-right in NFTs. We might want to address this in a subsequent PR. 
|
matthewwalsh0
approved these changes
Dec 11, 2024
NidhiKJha
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.10.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default position of the network avatar to the bottomRight of the token. It also changes the default shape from a circle to a rounded square
Figma: https://www.figma.com/design/IuOIRmU3wI0IdJIfol0ESu/Cross-Chain-Swaps?node-id=7-24563&node-type=canvas&m=dev
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist