-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Token list should respect hideZeroBalance
setting
#29058
Merged
Merged
+29
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…rendered for non-native assets
…tamask-extension into fix/12.9-zero-balance-tokens
Builds ready [73bd217]
Page Load Metrics (2601 ± 358 ms)
Bundle size diffs
|
bergeron
reviewed
Dec 10, 2024
gambinish
added
the
regression-RC-12.9
Regression bug that was found in release candidate (RC) for release 12.9
label
Dec 10, 2024
bergeron
previously approved these changes
Dec 10, 2024
darkwing
reviewed
Dec 10, 2024
…tamask-extension into fix/12.9-zero-balance-tokens
darkwing
added
the
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
label
Dec 10, 2024
… AllNetworks is selected
darkwing
previously approved these changes
Dec 10, 2024
7 tasks
sahar-fehri
previously approved these changes
Dec 10, 2024
bergeron
approved these changes
Dec 11, 2024
vinnyhoward
approved these changes
Dec 11, 2024
darkwing
approved these changes
Dec 11, 2024
Builds ready [e2cac2a]
Page Load Metrics (2275 ± 167 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.10.1
Issue or pull request that will be included in release 12.10.1
label
Dec 11, 2024
gambinish
changed the title
fix: Token list should respect hidezerobalance setting
fix: Token list should respect Dec 11, 2024
hideZeroBalance
setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
regression-RC-12.9
Regression bug that was found in release candidate (RC) for release 12.9
release-12.10.1
Issue or pull request that will be included in release 12.10.1
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a token is not a native asset for a chain, and the balance is zero, it should not be rendered if the
hideZeroBalance
setting is toggled to true.Related issues
Fixes: erc20 and native tokens with zero balance rendering on asset list on 12.9 release.
Manual testing steps
hideZeroBalance
setting to true in general settingsScreenshots/Recordings
Screen.Recording.2024-12-10.at.3.21.09.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist