fix: fix sticky autodetection banner #29061

salimtb · 2024-12-10T18:26:07Z

Description

fix sticky autodetection banner

Related issues

Fixes: #29059

Manual testing steps

Go to autodetected banner
click on ignore all
you should have allNetworks selected

Screenshots/Recordings

Before

After

https://drive.google.com/file/d/11zcmgV1Bdq5wx9MkDlhxr8oDBr9DGB3d/view?usp=sharing

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-10T18:26:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-10T19:00:50Z

Builds ready [d546ce6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1924 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	232	2208	1695	594	285
		domContentLoaded	1581	2147	1891	145	70
		load	1589	2200	1924	153	73
		domInteractive	25	93	39	18	9
		backgroundConnect	6	62	32	19	9
		firstReactRender	15	88	22	15	7
		getState	85	357	137	52	25
		initialActions	0	1	0	0	0
		loadScripts	1173	1743	1493	140	67
		setupStore	7	10	8	1	0
		uiStartup	1808	2848	2201	219	105

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 19 Bytes (0.00%)
common: 0 Bytes (0.00%)

salimtb · 2024-12-10T19:38:04Z

ui/components/app/detected-token/detected-token.js


          await dispatch(
            ignoreTokens({
-              tokensToIgnore: tokens,
+              tokensToIgnore,


ignoreTokens should be called with an array of strings

...nts/app/detected-token/detected-token-ignored-popover/detected-token-ignored-popover.test.js

metamaskbot · 2024-12-10T20:59:41Z

Builds ready [acc30ae]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1862 ± 126 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	268	2478	1787	431	207
		domContentLoaded	1552	2468	1835	257	123
		load	1572	2515	1862	262	126
		domInteractive	24	62	35	12	6
		backgroundConnect	7	70	30	18	9
		firstReactRender	14	26	18	3	2
		getState	86	172	124	22	11
		initialActions	0	1	0	0	0
		loadScripts	1197	1989	1449	215	103
		setupStore	6	11	8	1	1
		uiStartup	1779	2837	2133	284	136

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 81 Bytes (0.00%)
common: 0 Bytes (0.00%)

bergeron · 2024-12-10T21:17:09Z

...en/detected-token-ignored-popover/__snapshots__/detected-token-ignored-popover.test.tsx.snap

+exports[`DetectedTokenIgnoredPopover should match snapshot for ignore mode 1`] = `<DocumentFragment />`;
+
+exports[`DetectedTokenIgnoredPopover should match snapshot for import mode 1`] = `<DocumentFragment />`;


These snapshots are empty, so they aren't testing anything. I think modals have to be snapshotted differently, I'll see if i can find an example

I think this does it:
0f5eda3

metamaskbot · 2024-12-10T21:55:52Z

Builds ready [78ab85f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2027 ± 126 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	250	2402	1835	527	253
		domContentLoaded	1671	2356	2002	253	122
		load	1690	2413	2027	262	126
		domInteractive	23	121	45	23	11
		backgroundConnect	9	83	28	25	12
		firstReactRender	15	100	36	31	15
		getState	106	384	170	68	33
		initialActions	0	1	0	0	0
		loadScripts	1266	1815	1546	205	99
		setupStore	6	14	9	2	1
		uiStartup	1939	3298	2440	420	202

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 81 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot added the team-assets label Dec 10, 2024

salimtb force-pushed the fix-ignore-tokens-flow branch from 444c738 to d546ce6 Compare December 10, 2024 18:27

salimtb force-pushed the fix-ignore-tokens-flow branch from d546ce6 to d190575 Compare December 10, 2024 19:37

salimtb commented Dec 10, 2024

View reviewed changes

salimtb marked this pull request as ready for review December 10, 2024 19:38

fix: fix sticky autodetection banner

cc53eab

salimtb force-pushed the fix-ignore-tokens-flow branch from d190575 to cc53eab Compare December 10, 2024 19:39

salimtb commented Dec 10, 2024

View reviewed changes

...nts/app/detected-token/detected-token-ignored-popover/detected-token-ignored-popover.test.js Outdated Show resolved Hide resolved

Merge branch 'main' into fix-ignore-tokens-flow

740fedd

salimtb added the regression-prod-* Regression bug that was found in production in release * label Dec 10, 2024

salimtb force-pushed the fix-ignore-tokens-flow branch from 71beac5 to 215d104 Compare December 10, 2024 19:51

fix: fix sticky autodetection banner

61628d1

salimtb force-pushed the fix-ignore-tokens-flow branch from 215d104 to 61628d1 Compare December 10, 2024 19:51

fix: fix tests

acc30ae

bergeron reviewed Dec 10, 2024

View reviewed changes

bergeron added 2 commits December 10, 2024 13:21

fix snapshots

0f5eda3

Merge branch 'main' into fix-ignore-tokens-flow

78ab85f

bergeron approved these changes Dec 10, 2024

View reviewed changes

sahar-fehri approved these changes Dec 10, 2024

View reviewed changes

bergeron added this pull request to the merge queue Dec 10, 2024

Merged via the queue into main with commit 5789e1c Dec 10, 2024
75 checks passed

bergeron deleted the fix-ignore-tokens-flow branch December 10, 2024 22:05

github-actions bot locked and limited conversation to collaborators Dec 10, 2024

metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 10, 2024

salimtb added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix sticky autodetection banner #29061

fix: fix sticky autodetection banner #29061

salimtb commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024

metamaskbot commented Dec 10, 2024

salimtb Dec 10, 2024

metamaskbot commented Dec 10, 2024

bergeron Dec 10, 2024

bergeron Dec 10, 2024

metamaskbot commented Dec 10, 2024

		exports[`DetectedTokenIgnoredPopover should match snapshot for ignore mode 1`] = `<DocumentFragment />`;

		exports[`DetectedTokenIgnoredPopover should match snapshot for import mode 1`] = `<DocumentFragment />`;

fix: fix sticky autodetection banner #29061

fix: fix sticky autodetection banner #29061

Conversation

salimtb commented Dec 10, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 10, 2024

metamaskbot commented Dec 10, 2024

salimtb Dec 10, 2024

Choose a reason for hiding this comment

metamaskbot commented Dec 10, 2024

bergeron Dec 10, 2024

Choose a reason for hiding this comment

bergeron Dec 10, 2024

Choose a reason for hiding this comment

metamaskbot commented Dec 10, 2024

salimtb commented Dec 10, 2024 •

edited

Loading