-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Init getTokenNetworkFilter selector #29068
Merged
Merged
+37
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
bergeron
previously approved these changes
Dec 10, 2024
Builds ready [ec3c973]
Page Load Metrics (1929 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergeron
approved these changes
Dec 10, 2024
Builds ready [04f0f31]
Page Load Metrics (2103 ± 140 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
added
the
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
label
Dec 10, 2024
darkwing
approved these changes
Dec 10, 2024
Please fill out the PR template! |
7 tasks
metamaskbot
added
the
release-12.10.1
Issue or pull request that will be included in release 12.10.1
label
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.10.1
Issue or pull request that will be included in release 12.10.1
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are falling back to an empty object when tokenNetworkFilter is undefined in several areas around the app. This PR aims to consolidate those within a single selector to make is easier to maintain and fall back on.
This only mitigates the issue. Root cause is that the
tokenNetworkFilter
needs to be added via a migration script in order to properly be present, without having to fallback.Related issues
Fixes: https://metamask.sentry.io/issues/6125799129/?environment=production&project=273505&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20firstRelease%3A12.9.0&referrer=issue-stream&sort=freq&statsPeriod=7d&stream_index=0
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist