-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide first interaction alert if token transfer recipient is internal account #29389
Merged
matthewwalsh0
merged 4 commits into
main
from
fix/first-time-interaction-token-transfer-internal
Dec 20, 2024
Merged
fix: hide first interaction alert if token transfer recipient is internal account #29389
matthewwalsh0
merged 4 commits into
main
from
fix/first-time-interaction-token-transfer-internal
Dec 20, 2024
+141
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
previously approved these changes
Dec 20, 2024
OGPoyraz
previously approved these changes
Dec 20, 2024
vinistevam
previously approved these changes
Dec 20, 2024
pedronfigueiredo
previously approved these changes
Dec 20, 2024
matthewwalsh0
dismissed stale reviews from pedronfigueiredo, vinistevam, and OGPoyraz
via
December 20, 2024 17:18
507a418
matthewwalsh0
requested review from
vinistevam,
pedronfigueiredo and
OGPoyraz
December 20, 2024 18:10
pedronfigueiredo
approved these changes
Dec 20, 2024
Builds ready [2c9c8f9]
Page Load Metrics (1707 ± 69 ms)
Bundle size diffs
|
OGPoyraz
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 20, 2024
matthewwalsh0
deleted the
fix/first-time-interaction-token-transfer-internal
branch
December 20, 2024 21:29
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide the first-time interaction alert if the transaction is a token transfer, and the recipient is an internal account.
Related issues
Fixes: #29225
Manual testing steps
Create token transfer to internal account and verify no alert is displayed.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist