Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide first interaction alert if token transfer recipient is internal account #29389

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Dec 20, 2024

Description

Hide the first-time interaction alert if the transaction is a token transfer, and the recipient is an internal account.

Open in GitHub Codespaces

Related issues

Fixes: #29225

Manual testing steps

Create token transfer to internal account and verify no alert is displayed.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Dec 20, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner December 20, 2024 14:12
OGPoyraz
OGPoyraz previously approved these changes Dec 20, 2024
vinistevam
vinistevam previously approved these changes Dec 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [2c9c8f9]
Page Load Metrics (1707 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15162034170613464
domContentLoaded14681971168413364
load14772034170714469
domInteractive267338147
backgroundConnect106428199
firstReactRender1676402612
getState56014157
initialActions01000
loadScripts10631488124311656
setupStore65514157
uiStartup17322284194715776
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.08 KiB (0.01%)
  • common: 0 Bytes (0.00%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit f64a2d0 Dec 20, 2024
77 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/first-time-interaction-token-transfer-internal branch December 20, 2024 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
5 participants