Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor marker config macros #94

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Refactor marker config macros #94

merged 2 commits into from
Dec 31, 2023

Conversation

Timi007
Copy link
Member

@Timi007 Timi007 commented Dec 30, 2023

When merged this pull request will:

  • Reduce amount of macros needed to declare icons and modifier
  • Remove marker file macros

@Timi007 Timi007 added the optimization Everything is going to be better with this, trust me label Dec 30, 2023
@Timi007 Timi007 added this to the 1.8.1 milestone Dec 30, 2023
@Timi007 Timi007 requested a review from PhILoXs December 30, 2023 16:52
@Timi007 Timi007 merged commit 0acf82a into master Dec 31, 2023
2 checks passed
@Timi007 Timi007 deleted the refactor_macros branch December 31, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhILoXs PhILoXs PhILoXs approved these changes

Assignees
No one assigned
Labels
optimization Everything is going to be better with this, trust me
Projects
None yet
Milestone
1.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Timi007 @PhILoXs