Simple movie search application exercise - Jan Escorza #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bar results intoroduce a debouncing hook to search after using finishes typing, fetch results with a kayak search engine delay and display results in cards that highlight top rated, hide invalid dates and are arranged in movie list grid
The search and movie details views are now independent and both access the movie context for better state handling, the movie list now allows for extra page loads and the loaded movies together eith the context are leveraged as a cache to avoid refetching
…th very minor fixes The tests are comprehensive but do not cover all edge cases a the moment, and some minor changes were introduced as I found them necessary when developing the tests.
…api handling Cleaned code and added comments to the theme provider and app. Refactored movieApi to include timeout and retry mechanisms, response validation, and improved type safety for fetching movie data.
use transient prop to avoid the rating prop being passed to the underlying DOM element
funnily enough I didnt realize that I messed up the overall styling cause I had the dev tools open hahahah but np , all is good :D this is why you also want more snapshot tests and on different devices. Will anyone ever read this? If so, remember that the mitochondria is the powerhouse of the cell!
…urther comments so this is my last commit before presenting to the stakeholders yay! anyway, while identifying everything that could be improved, there were a couple things such as classnames, consistent use of styled components, less terrible error handling for the movie details page that I adressed direclty. What a cute little repo this is turning into :3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces my proposed solution for the clean and simple movie search application exercise I have built with React and TypeScript. I have included a
README.mdfile with a simple project overview, features, installation instructions, and available scripts.Although I am excited to go over it all with you! :) 🙌
There is a chance I make some clean-up changes, add further comments to make going through it all easier during the call or other minor changes if I find the time before the next interview