This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
[bug fix] Fix auto grouping doesn't work because isOn is undefined by default #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theres' a bug that auto grouping doesn't work.
This is because in
background.ts
, it executes auto grouping only when Chrome local storageisOn
istrue
.However,
isOn
is by defaultundefined
, becausepopup.tsx
doesn't storeisOn
value to Chrome local storage, as the only place it sets is when user clicks ondisableGrouping
.Since
isOn
isundefined
,backtround.ts
won't execute auto grouping.This PR fixes this.
#48 is aimed to avoid such bugs when these states should have been synced across browser storage and React states.