-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite TemplateExpression
to enable hierarchical expressions
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Pull Request Test Coverage Report for Build 11717823949Details
💛 - Coveralls |
MilesCranmer
commented
Nov 5, 2024
MilesCranmer
force-pushed
the
composable-expressions
branch
2 times, most recently
from
November 7, 2024 05:00
8288720
to
277ffe9
Compare
MilesCranmer
force-pushed
the
composable-expressions
branch
from
November 7, 2024 06:08
277ffe9
to
9f0261d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComposableExpression
type for building composable mathematical formulas. You can even call these on other expressions to use them like macros.ValidVector
wrapper to handle invalid computation results (e.g., NaN) safely within theTemplateExpression
ValidVector
to propagate validity flagsThis enables building complex expressions that can be hierarchical (!).