Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Optim to 1, (keep existing compat) #369

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Optim package from ~1.8, ~1.9 to ~1.8, ~1.9, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Contributor Author

Benchmark Results

master a41c96d... master/a41c96dc125c09...
search/multithreading 21.5 ± 1.1 s 21.2 ± 1.1 s 1.01
search/serial 33.2 ± 2.2 s 32 ± 1.2 s 1.03
utils/best_of_sample 1.66 ± 1.3 μs 1.8 ± 1.6 μs 0.922
utils/check_constraints_x10 11.9 ± 3.2 μs 12 ± 3.2 μs 0.991
utils/compute_complexity_x10/Float64 2.09 ± 0.11 μs 2.08 ± 0.12 μs 1
utils/compute_complexity_x10/Int64 2.06 ± 0.12 μs 2.04 ± 0.11 μs 1.01
utils/compute_complexity_x10/nothing 1.41 ± 0.11 μs 1.39 ± 0.1 μs 1.02
utils/insert_random_op_x10 5.75 ± 1.9 μs 5.88 ± 1.9 μs 0.978
utils/next_generation_x100 0.35 ± 0.13 ms 0.437 ± 0.12 ms 0.801
utils/optimize_constants_x10 0.035 ± 0.0078 s 0.0358 ± 0.0084 s 0.978
utils/randomly_rotate_tree_x10 5.33 ± 0.61 μs 5.29 ± 0.61 μs 1.01
time_to_load 1.75 ± 0.0079 s 1.75 ± 0.0024 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit de9f67b into master Nov 20, 2024
15 checks passed
@MilesCranmer MilesCranmer deleted the compathelper/new_version/2024-11-13-00-11-48-590-01849372281 branch November 20, 2024 10:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11930414380

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.462%

Files with Coverage Reduction New Missed Lines %
src/AdaptiveParsimony.jl 1 96.88%
Totals Coverage Status
Change from base Build 11775142239: -0.03%
Covered Lines: 3113
Relevant Lines: 3261

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants