Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: widen type constraints for TemplateExpression evaluation #371

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

MilesCranmer
Copy link
Owner

No description provided.

Copy link
Contributor

github-actions bot commented Nov 24, 2024

Benchmark Results

master c262642... master/c262642711b53a...
search/multithreading 22.3 ± 1 s 21 ± 1.9 s 1.06
search/serial 35.1 ± 0.35 s 33.3 ± 0.4 s 1.05
utils/best_of_sample 1.75 ± 1.5 μs 2.06 ± 1.6 μs 0.85
utils/check_constraints_x10 12.1 ± 3.2 μs 12.2 ± 3.2 μs 0.987
utils/compute_complexity_x10/Float64 2.12 ± 0.11 μs 2.09 ± 0.11 μs 1.01
utils/compute_complexity_x10/Int64 2.06 ± 0.12 μs 2.05 ± 0.11 μs 1
utils/compute_complexity_x10/nothing 1.43 ± 0.12 μs 1.44 ± 0.13 μs 0.993
utils/insert_random_op_x10 5.87 ± 1.9 μs 5.85 ± 1.8 μs 1
utils/next_generation_x100 0.363 ± 0.12 ms 0.444 ± 0.12 ms 0.818
utils/optimize_constants_x10 0.0394 ± 0.009 s 0.0378 ± 0.0085 s 1.04
utils/randomly_rotate_tree_x10 5.26 ± 0.6 μs 5.21 ± 0.57 μs 1.01
time_to_load 1.81 ± 0.025 s 1.81 ± 0.0055 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer changed the title fix: widen type constraints for TemplateExpression fix: widen type constraints for TemplateExpression evaluation Nov 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11992818084

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.462%

Totals Coverage Status
Change from base Build 11932767677: 0.0%
Covered Lines: 3113
Relevant Lines: 3261

💛 - Coveralls

@MilesCranmer MilesCranmer merged commit dedb41a into master Nov 24, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the fix-type-constraints branch November 24, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants