-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-use allocations in mutation loop #387
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Pull Request Test Coverage Report for Build 12323432167Details
💛 - Coveralls |
Hm. There’s no speedup… not sure it’s worth the added complexity? Edit: made the interface have a fallback, it seems ok now. My guess is that the perf gains will be on larger systems with larger trees where the extra copies hurt |
0c46f4a
to
227f55f
Compare
227f55f
to
19eeb11
Compare
This re-uses allocations in the mutation loop. This should hopefully result in a nice speed up from reduced need for garbage collection.