Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add safe versions of asin and acos #388

Merged
merged 8 commits into from
Dec 14, 2024
Merged

feat: add safe versions of asin and acos #388

merged 8 commits into from
Dec 14, 2024

Conversation

MilesCranmer
Copy link
Owner

No description provided.

Copy link
Contributor

github-actions bot commented Dec 14, 2024

Benchmark Results

master 235bde6... master/235bde6efd51e6...
search/multithreading 16.7 ± 1.6 s 17.5 ± 1.2 s 0.956
search/serial 28.4 ± 0.06 s 27.5 ± 0.11 s 1.03
utils/best_of_sample 1.62 ± 0.35 μs 1.72 ± 0.66 μs 0.942
utils/check_constraints_x10 11.3 ± 3 μs 11.2 ± 2.8 μs 1.01
utils/compute_complexity_x10/Float64 2.06 ± 0.11 μs 2.09 ± 0.11 μs 0.986
utils/compute_complexity_x10/Int64 2.01 ± 0.11 μs 2.06 ± 0.11 μs 0.976
utils/compute_complexity_x10/nothing 1.38 ± 0.1 μs 1.41 ± 0.12 μs 0.979
utils/insert_random_op_x10 5.69 ± 1.9 μs 5.76 ± 1.8 μs 0.988
utils/next_generation_x100 0.35 ± 0.095 ms 0.358 ± 0.1 ms 0.977
utils/optimize_constants_x10 0.0345 ± 0.0077 s 0.0339 ± 0.0083 s 1.02
utils/randomly_rotate_tree_x10 5.3 ± 0.62 μs 5.24 ± 0.6 μs 1.01
time_to_load 1.91 ± 0.025 s 1.84 ± 0.032 s 1.04

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@coveralls
Copy link

coveralls commented Dec 14, 2024

Pull Request Test Coverage Report for Build 12332615270

Details

  • 31 of 46 (67.39%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 94.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Options.jl 10 14 71.43%
src/Operators.jl 21 32 65.63%
Files with Coverage Reduction New Missed Lines %
src/Operators.jl 1 70.0%
Totals Coverage Status
Change from base Build 12324553806: -0.4%
Covered Lines: 3142
Relevant Lines: 3317

💛 - Coveralls

@MilesCranmer

This comment was marked as resolved.

@MilesCranmer MilesCranmer merged commit c52b36d into master Dec 14, 2024
17 checks passed
@MilesCranmer MilesCranmer deleted the asin branch December 14, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants