Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate MutableStoreBuilder from StoreBuilder #542

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

matt-ramotar
Copy link
Collaborator

Store5's StoreBuilder caused a breaking change. See #532. We can avoid this breaking change by introducing a separate builder for MutableStore.

digitalbuddha
digitalbuddha previously approved these changes Mar 31, 2023
Copy link
Contributor

@digitalbuddha digitalbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to go from a store builder to a mutable store builder. On phone and didn't see it

@matt-ramotar
Copy link
Collaborator Author

@digitalbuddha Not currently. Will add 👍🏽

digitalbuddha
digitalbuddha previously approved these changes Mar 31, 2023
@matt-ramotar matt-ramotar force-pushed the matt-ramotar/builder branch from 5516dd5 to 441de88 Compare March 31, 2023 18:28
Signed-off-by: Matt Ramotar <[email protected]>
@matt-ramotar matt-ramotar merged commit e050a15 into main Apr 13, 2023
@matt-ramotar matt-ramotar deleted the matt-ramotar/builder branch April 13, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants