Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades netlify-cli to remove static-server dependency #145

Closed
wants to merge 2 commits into from

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Oct 27, 2023

Fixes #134

Steps taken:

  1. Set netlify-cli dependency to ^13.0.0 (first major version that does not include static-server) in devDependencies in package.json
  2. Run yarn install locally
  3. Test that the website builds locally with yarn dev
  4. Commit and push the changes made to package.json and yarn.lock
  5. The automated unit tests fail ❌

@richfab richfab linked an issue Oct 27, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for gbfs-validator failed.

Name Link
🔨 Latest commit 431e859
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/653fdc343a505b00088e82be

@richfab
Copy link
Contributor Author

richfab commented Oct 27, 2023

The website builds locally but this error occurs when validating a feed:
image

If someone has some tips, feel free to help 🙏 Thank you!

EDIT: The error described above was due to my local env, not to the netlify-cli version.

@richfab richfab marked this pull request as draft October 27, 2023 16:47
@richfab richfab added the help wanted Extra attention is needed label Oct 27, 2023
@testower
Copy link
Collaborator

I can have a look @richfab

@testower
Copy link
Collaborator

I was able to pin the error in the install step down to the upgrade from v13 to v14, but can't really understand why.

The website builds locally but this error occurs when validating a feed:

This happens even in master. I think the problem is that you have to authenticate with netlify for this to work.

@testower
Copy link
Collaborator

testower commented Oct 30, 2023

🥶

Very strange, the unit tests passed with v13 here https://github.com/entur/gbfs-validator/actions/runs/6671621967/job/18133905807

@richfab
Copy link
Contributor Author

richfab commented Oct 30, 2023

In my previous local tests, the argument -- filter website was causing the feed validation error.

Here are the next steps I took:

  1. Used @testower tests in Incremental upgrade #146 to see that ^13.0.0 is the first major version that does not include static-server.
  2. Set netlify-cli dependency to ^13.0.0 in devDependencies in package.json
  3. Run yarn install locally
  4. Test that the website builds locally with yarn dev
  5. Commit and push the changes made to package.json and yarn.lock
  6. The automated unit tests fail ❌

The unit tests seem to fail when trying to install esbuild https://github.com/MobilityData/gbfs-validator/actions/runs/6695935881/job/18195967695#step:4:48.

Due to the low priority of this issue (#134 (comment)), I will close this draft PR for now.

@richfab richfab closed this Oct 30, 2023
@richfab richfab changed the title Upgrades netlify-cli to latest v16.9.2 Upgrades netlify-cli to remove static-server dependency Oct 30, 2023
@richfab
Copy link
Contributor Author

richfab commented Oct 30, 2023

🥶

Very strange, the unit tests passed with v13 here https://github.com/entur/gbfs-validator/actions/runs/6671621967/job/18133905807

Very strange indeed 🤔

@richfab richfab removed the help wanted Extra attention is needed label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major issue with static-server
2 participants