-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades netlify-cli to remove static-server dependency #145
Conversation
❌ Deploy Preview for gbfs-validator failed.
|
I can have a look @richfab |
I was able to pin the error in the install step down to the upgrade from v13 to v14, but can't really understand why.
This happens even in master. I think the problem is that you have to authenticate with netlify for this to work. |
🥶 Very strange, the unit tests passed with v13 here https://github.com/entur/gbfs-validator/actions/runs/6671621967/job/18133905807 |
In my previous local tests, the argument Here are the next steps I took:
The unit tests seem to fail when trying to install Due to the low priority of this issue (#134 (comment)), I will close this draft PR for now. |
Very strange indeed 🤔 |
Fixes #134
Steps taken:
netlify-cli
dependency to^13.0.0
(first major version that does not includestatic-server
) indevDependencies
in package.jsonyarn install
locallyyarn dev
✅