Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema id URL from NABSA to MobilityData repo #158

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Nov 21, 2023

Fixes MobilityData/gbfs-json-schema#101

This PR updates the schema id URLs from NABSA to MobilityData repo and fixes the anchors:

Before After
"https://github.com/NABSA/gbfs/blob/v3.0-RC/gbfs.md#vehicle_typesjson-added-in-v21-rc", "https://github.com/MobilityData/gbfs/blob/v3.0-RC/gbfs.md#vehicle_typesjson"-added-in-v21-rc,

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit 3725f40
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/655e5e65874fea00084adac8
😎 Deploy Preview https://deploy-preview-158--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richfab richfab requested a review from davidgamez November 21, 2023 21:20
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few additions of uniqueness in an array that are out of the scope of this PR. Please consider creating a separate PR for those changes.

gbfs-validator/versions/schemas/v2.3/vehicle_types.json Outdated Show resolved Hide resolved
gbfs-validator/versions/schemas/v2.3/system_alerts.json Outdated Show resolved Hide resolved
gbfs-validator/versions/schemas/v2.3/station_status.json Outdated Show resolved Hide resolved
gbfs-validator/versions/schemas/v2.0/system_alerts.json Outdated Show resolved Hide resolved
gbfs-validator/versions/schemas/v2.3/geofencing_zones.json Outdated Show resolved Hide resolved
@richfab
Copy link
Contributor Author

richfab commented Nov 22, 2023

Good catch @davidgamez! I removed the validation of uniqueness from this PR and moved it to a separate PR: #159

@richfab
Copy link
Contributor Author

richfab commented Dec 4, 2023

@davidgamez This PR is ready for review. Thank you!

@richfab richfab requested review from davidgamez and removed request for davidgamez December 4, 2023 15:10
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richfab richfab merged commit 8ffc58f into master Dec 5, 2023
7 checks passed
@richfab richfab deleted the fix/schema-id-mobilitydata branch December 5, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update schema id URL from NABSA to MobilityData repo
3 participants