-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema id URL from NABSA to MobilityData repo #158
Conversation
✅ Deploy Preview for gbfs-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few additions of uniqueness in an array that are out of the scope of this PR. Please consider creating a separate PR for those changes.
gbfs-validator/versions/schemas/v3.0-RC2/station_information.json
Outdated
Show resolved
Hide resolved
Good catch @davidgamez! I removed the validation of uniqueness from this PR and moved it to a separate PR: #159 |
@davidgamez This PR is ready for review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes MobilityData/gbfs-json-schema#101
This PR updates the schema id URLs from NABSA to MobilityData repo and fixes the anchors:
"https://github.com/NABSA/gbfs/blob/v3.0-RC/gbfs.md#vehicle_typesjson-added-in-v21-rc"
,"https://github.com/MobilityData/gbfs/blob/v3.0-RC/gbfs.md#vehicle_typesjson"
-added-in-v21-rc,