Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modified to display that there is an error if a required file is missing #169

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Jan 26, 2024

Closes #127
Modified to display Invalid GBFS feed if a required file is missing.

Here is the results when using this feed

image

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit d3c038c
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/65b993bc4b20f0000832904f
😎 Deploy Preview https://deploy-preview-169--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jcpitre jcpitre requested a review from richfab January 26, 2024 20:40
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @jcpitre 🎉

@richfab richfab requested a review from davidgamez January 29, 2024 06:38
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidgamez davidgamez changed the title Modified to display that there is an error if a required file is missing fix: Modified to display that there is an error if a required file is missing Jan 31, 2024
@jcpitre jcpitre merged commit a8f775a into master Jan 31, 2024
7 checks passed
@jcpitre jcpitre deleted the 127-gbfsjson-present-all-other-files-missing-validator-says-valid branch January 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gbfs.json present, all other files missing, validator says "valid"
3 participants