Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect field fixes #336

Merged
merged 2 commits into from
Feb 16, 2024
Merged

fix: redirect field fixes #336

merged 2 commits into from
Feb 16, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Feb 16, 2024

Introduces fixes to #319:

  • None is now supported for redirects -- the result will be an empty array
  • Tests are fixed -- they set an numerical id for the redirect instead of a string

@fredericsimard fredericsimard merged commit 5b424f1 into main Feb 16, 2024
8 checks passed
@fredericsimard fredericsimard deleted the feat/319-fix branch February 16, 2024 14:53
Copy link
Contributor

@fredericsimard fredericsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants