Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new is_official tag for feeds #649

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lawrencefan506
Copy link

Adding a new optional tag called 'is_official' for feeds as requested in issue #356.

Changes:

  • Updated schemas in schemas/gtfs_realtime_source_schema.json and schemas/gtfs_schedule_source_schema.json to include this tag.
  • Updated `tools/constants.py' to include this tag.
  • Updated tools/representations.py, adding this tag to the Source class.
  • Created, in tools/representations.py, a has_is_official method for the GtfsScheduleSource and GtfsRealtimeSource classes and a get_sources_by_is_official method for the SourcesCatalog class.
  • Created test cases in tools/tests/test_representations.py for each new method listed above. All passed locally.
  • Created get_sources_by_is_official method in tools/operations.py.
  • Created test case in tools/tests/test_operations.py for the new method listed above. Passed locally.
  • Updated README.md schemas to include this tag.

…ary functions in representations.py. Added test case in test_operations.py for get_sources_by_is_official function - Passed.
…y_is_official, test_has_is_official for both GtfsScheduleSource and GtfsRealtimeSource. All passed.
@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants