fix: making the uploaded files public

MobilityData · Sep 27, 2023 · 9b58926 · 9b58926
1 parent 24d668e
commit 9b58926
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/infra/batch/datasets/main.py b/infra/batch/datasets/main.py
@@ -80,6 +80,7 @@ def upload_dataset(url, bucket_name, stable_id, latest_hash):
         timestamp = current_time.strftime("%Y%m%d")
         timestamp_blob = bucket.blob(f"{stable_id}/{timestamp}.zip")
         timestamp_blob.upload_from_string(content, timeout=300)
+        timestamp_blob.make_public()
         return file_sha256_hash, timestamp_blob.public_url
 
     else:

diff --git a/infra/batch/main.tf b/infra/batch/main.tf
@@ -33,13 +33,6 @@ resource "google_storage_bucket" "bucket" {
   location = var.gcp_region
 }
 
-resource "google_storage_bucket_acl" "my_bucket_acl" {
-  bucket = google_storage_bucket.bucket.name
-  role_entity = [
-    "READER:allUsers"
-  ]
-}
-
 
 resource "google_storage_bucket_object" "object" {
   name            = "${var.source_code_path}${filesha256(var.source_code_zip_file)}.zip"