feat: GTFS feeds sorting by external_id and country_code #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goorui
force-pushed
the
haorui/gtfs_sorting
branch
from
d282242 to
125343a
Compare
goorui
changed the title
goorui
force-pushed
the
haorui/gtfs_sorting
branch
from
125343a to
343aab3
Compare
jujiang526
approved these changes
Oct 4, 2023
indraneel
approved these changes
Oct 4, 2023
| def _get_order_by_key(order_by: list[str] = None): | ||
| order_by_columns = [] | ||
| for field in order_by: | ||
| if "country_code" in field: |
There was a problem hiding this comment.
approving, but wondering if we shouldn't just make it if field == "-country_code" and so on
indraneel
approved these changes
Oct 5, 2023
added 2 commits
October 5, 2023 15:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #82
Expected behavior:
Enable sorting on gtfs_feeds api
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything