Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python functions service account reference #212

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Jan 4, 2024

Summary:

PR #196 changed the service account to be used in the Python functions and broke the deployment.

Expected behavior:

The correct service account is referenced by the python functions.

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
Copy link
Member Author

Verified by:

curl --location 'https://api-dev.mobilitydatabase.org/v1/tokens' \
--header 'Content-Type: application/json' \
--data '{
    "refresh_token": "[*****]"
}'

@davidgamez davidgamez marked this pull request as ready for review January 4, 2024 21:36
@davidgamez davidgamez requested a review from cka-y January 4, 2024 21:36
@cka-y cka-y merged commit fbf8c6e into main Jan 4, 2024
4 checks passed
@cka-y cka-y deleted the fix/python-functions-sa branch January 4, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants