Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/615 long provider names #677

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

Alessandro100
Copy link
Contributor

@Alessandro100 Alessandro100 commented Aug 14, 2024

closes #615
Summary:

Long provider names which were separated by commas are now formatted. Includes translations

Expected behavior:

When looking at transit agencies with long provider names, they should be formatted nicely (see screenshots)

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Screenshot 2024-08-14 at 11 15 34
Screenshot 2024-08-14 at 11 16 02
Screenshot 2024-08-14 at 11 16 20
Screenshot 2024-08-14 at 11 16 30
Screenshot 2024-08-14 at 11 16 46

@Alessandro100 Alessandro100 self-assigned this Aug 14, 2024
@Alessandro100 Alessandro100 marked this pull request as ready for review August 14, 2024 15:20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By having test files that focus on the component, it will reduce the amount of Cypress tests we need to write

Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-677-cjlqpd90.web.app

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 The UI component testing is an excellent addition! Also, I love to see the translation keys flowing into the pages that were developed before adding the internationalization framework. 🥇

@Alessandro100 Alessandro100 merged commit 92a1141 into main Aug 14, 2024
4 checks passed
@Alessandro100 Alessandro100 deleted the feat/615-long-provider-names branch August 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include full list of transit providers included in the feed summary section in cases where there are multiple
2 participants