-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tl scraping function #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added @AlfredNwolisa for visibility |
davidgamez
reviewed
Dec 6, 2024
:return: feed_url in mbd if exists, otherwise None | ||
""" | ||
results = ( | ||
db_session.query(Gtfsfeed) | ||
.filter(Gtfsfeed.externalids.any(associated_id=external_id)) | ||
db_session.query(Feed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
davidgamez
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces several enhancements and fixes to improve error handling, logging, and data extraction in the
functions-python
project. Key changes include robust error handling in theprocess_dataset
function, updates to theTransitFeedSyncProcessor
for better feed URL handling, and refactoring of test functions to align with the updated codebase.Closes https://github.com/MobilityData/product-tasks/issues/103)](https://github.com/MobilityData/product-tasks/issues/103
What was fixed:
stable_id
values.tld-*
feed IDs alongsidemdb-*
feed IDs.Additional updates:
Out of scope:
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything