Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow using GameCondition in EntityVehicleCondition and EntityPassengerCondition #11

Open
sylv256 opened this issue Nov 24, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@sylv256
Copy link
Member

sylv256 commented Nov 24, 2024

I've already found this annoying enough having to implement a RetypedCondition bodge, so this would be much appreciated.

@sylv256 sylv256 added bug Something isn't working enhancement New feature or request labels Nov 24, 2024
@sylv256
Copy link
Member Author

sylv256 commented Nov 24, 2024

I'm thinking of messing with InvertedCondition so that it's easier to use without retyping.

@sylv256
Copy link
Member Author

sylv256 commented Nov 24, 2024

I'm going to make a special Either codec that allows usage of either GameCondition or TypedGameCondition.

@sylv256
Copy link
Member Author

sylv256 commented Nov 24, 2024

Upon further investigation, this introduced unnecessary amounts of boilerplate. Instead, we're going to find alternative avenues of simplification. I believe the easiest way here would be to merged TypedGameCondition and GameCondition. However, that would present further challenges with regards to Codecs, so the best compromise would be to keep the current system of retyping for the time being.

@sylv256 sylv256 pinned this issue Nov 24, 2024
@sylv256 sylv256 added the help wanted Extra attention is needed label Nov 24, 2024
@sylv256 sylv256 added this to the 1.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant