Skip to content

Commit

Permalink
signal: implicit noexcept-ness for dtors
Browse files Browse the repository at this point in the history
  • Loading branch information
skypjack committed Sep 16, 2024
1 parent 33f00f4 commit 3f8efac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/entt/signal/dispatcher.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace entt {
namespace internal {

struct basic_dispatcher_handler {
virtual ~basic_dispatcher_handler() noexcept = default;
virtual ~basic_dispatcher_handler() = default;
virtual void publish() = 0;
virtual void disconnect(void *) = 0;
virtual void clear() noexcept = 0;
Expand Down Expand Up @@ -179,7 +179,7 @@ class basic_dispatcher {
}

/*! @brief Default destructor. */
~basic_dispatcher() noexcept = default;
~basic_dispatcher() = default;

/**
* @brief Default copy assignment operator, deleted on purpose.
Expand Down
2 changes: 1 addition & 1 deletion src/entt/signal/emitter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class emitter {
}

/*! @brief Default destructor. */
virtual ~emitter() noexcept {
virtual ~emitter() {
static_assert(std::is_base_of_v<emitter<Derived, Allocator>, Derived>, "Invalid emitter type");
}

Expand Down
4 changes: 2 additions & 2 deletions src/entt/signal/sigh.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class sigh<Ret(Args...), Allocator> {
: calls{std::move(other.calls), allocator} {}

/*! @brief Default destructor. */
~sigh() noexcept = default;
~sigh() = default;

/**
* @brief Copy assignment operator.
Expand Down Expand Up @@ -291,7 +291,7 @@ struct scoped_connection {
: conn{std::exchange(other.conn, {})} {}

/*! @brief Automatically breaks the link on destruction. */
~scoped_connection() noexcept {
~scoped_connection() {
conn.release();
}

Expand Down

0 comments on commit 3f8efac

Please sign in to comment.