Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/logger #36

Merged
merged 3 commits into from
May 6, 2024
Merged

Bugfix/logger #36

merged 3 commits into from
May 6, 2024

Conversation

97gamjak
Copy link
Collaborator

@97gamjak 97gamjak commented May 5, 2024

Modified the logger class, such that the Exception type is also included in the standard print information and now one can also check the exception type given to the logger via pytest.

Furthermore, small refactorings of trajectory.py due to some pylint issues.

@97gamjak 97gamjak requested a review from galjos May 5, 2024 22:38
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (cec6f78) to head (8694cd6).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #36      +/-   ##
==========================================
+ Coverage   77.23%   77.25%   +0.02%     
==========================================
  Files         118      118              
  Lines        4190     4195       +5     
==========================================
+ Hits         3236     3241       +5     
  Misses        954      954              
Flag Coverage Δ
unittests 77.25% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
PQAnalysis/traj/trajectory.py 100.00% <100.00%> (ø)
PQAnalysis/utils/custom_logging.py 72.44% <100.00%> (+1.48%) ⬆️

Copy link
Contributor

github-actions bot commented May 6, 2024

PYLINT REPORT

Your code has been rated at 9.87/10

Full report

Raw metrics

type number % previous difference
code 6403 38.60 NC NC
docstring 7739 46.66 NC NC
comment 215 1.30 NC NC
empty 2230 13.44 NC NC

Duplication

now previous difference
nb duplicated lines 0 NC NC
percent duplicated lines 0.000 NC NC

Messages by category

type number previous difference
convention 10 NC NC
refactor 36 NC NC
warning 6 NC NC
error 0 NC NC

Messages

message id occurrences
too-many-arguments 17
too-many-instance-attributes 10
invalid-name 9
fixme 6
too-many-locals 3
duplicate-code 2
too-many-statements 1
too-many-return-statements 1
too-many-branches 1
too-complex 1
missing-module-docstring 1

@galjos galjos merged commit 793b589 into dev May 6, 2024
6 checks passed
@galjos galjos deleted the bugfix/logger branch May 6, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants