Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix incorrect overwrite of XHR.open.
See also https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply.
If not pass all the arguments down to the original XHR.open, some ajax of jquery would be failed like
async: false
or authentication.I found this bug due to the
Biometric login
of https://ids.ynu.edu.cn/ isn't always shown if enabled this content script.After some debugging, I found it's an ajax call with
async: false
not working expected. The xhr.open is overwrited incorrect by this script. The third argumentasync
is not passed.See also the following snapshots.
m3u8-downloader/m3u8-downloader.user.js
Lines 106 to 117 in 6e4fddc