Factor file pos when hashing nodes

Muqsit · Sep 30, 2023 · 331b337 · 331b337
1 parent 98b8188
commit 331b337
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/ParsedFile.php b/src/ParsedFile.php
@@ -26,20 +26,20 @@
 final class ParsedFile{
 
 	public static function nodeHash(Node $node) : ?string{
-		$tokens = [$node->getLine(), $node->getStartLine(), $node->getEndLine(), $node->getStartTokenPos(), $node->getEndTokenPos()];
-		$add_non_expr_tokens = true;
+		$tokens = [
+			$node->getType(), $node->getLine(),
+			$node->getStartFilePos(), $node->getEndFilePos(),
+			$node->getStartLine(), $node->getEndLine(),
+			$node->getStartTokenPos(), $node->getEndTokenPos()
+		];
 		if($node instanceof Expr){
 			try{
 				static $printer = null;
 				$printer ??= new Standard();
 				$tokens[] = $printer->prettyPrintExpr($node);
-				$add_non_expr_tokens = false;
 			}catch(Error | Exception){
 			}
 		}
-		if($add_non_expr_tokens){
-			array_push($tokens, $node->getType(), $node->getStartLine(), $node->getEndLine(), $node->getStartTokenPos());
-		}
 		return implode(":", $tokens);
 	}