feature: additional SecLoop, ExprElement and EffWait syntax #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olyno
reviewed
Oct 17, 2020
src/main/java/io/github/syst3ms/skriptparser/sections/SecLoop.java
Outdated
Show resolved
Hide resolved
Olyno
previously approved these changes
Oct 19, 2020
Olyno
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds three simple syntaxes to some existing ones:
loop N timessyntax. I made it so that the actual code doesn't get looped N amount of times, but rather a range from 1 to N. This way, users can useloop-numberin their code to refer to the current iteration, something Skript has been missing for an eternity.wait while X (for Y time). Some small addition that Skript actually doesn't support. I had to revamp the ThreadUtils a bit for this.N random elementssyntax.Furthermore, I fixed one error in the SimpleLiteral class and fixed some error message in the ExprRange syntax class.
These syntaxes all came from the #40 issue.