✨ Introduce extensible settings rules for SetupRequest

[yoerriwalstra]

No description provided.

[yoan-myparcel]

I know I suggested exactly this code but I'm wondering, isn't the following the same?

Suggested change

	protected function settingsRules(): string|array
	{
	return 'array';
	}
	protected function settingsRules(): array
	{
	return ['array'];
	}

Just so we avoid having to return string as well. Not sure if it will work!

[yoerriwalstra]

it will work, but we lose the flexibility to return, for example

'array|size:3'

Now that I'm thinking about it longer, I don't see how this helps us validate individual settings. In case of pay.nl, we want to be able to validate not just data.settings, but specifically data.settings.api_code, data.settings.api_token and data.settings.service_id. All those keys have to go directly into the array that is returned by rules(), it won't work with:

protected function settingsRules(): array
{
    return [
        'api_code' => 'required|string',
        ...
    ];
}

so, perhaps we should keep this SetupRequest as is, extend it in integrations that require additional validation and override the rules method there, like you suggested earlier:

public function rules(): array
{
    $rules = parent::rules();

    $rules['data.settings.api_code'] = ...;
 
   return $rules;
}

[yoan-myparcel]

Closed because of @yoerriwalstra last comment - it is the case and we do not need this change in skeleton.