refactor: 코드스멜제거

Myongji-Graduate · Dec 22, 2024 · 0dbe1d6 · 0dbe1d6
1 parent 7beff95
commit 0dbe1d6
Show file tree

Hide file tree

Showing 6 changed files with 138 additions and 295 deletions.
diff --git a/...graduate/myongjigraduatebe/graduation/application/service/CalculateGraduationService.java b/...graduate/myongjigraduatebe/graduation/application/service/CalculateGraduationService.java
@@ -31,7 +31,7 @@ class CalculateGraduationService implements CalculateGraduationUseCase {
 
 
 	@Override
-	public GraduationResult calculateGraduation(User user) {
+	public  GraduationResult calculateGraduation(User user) {
 		GraduationRequirement graduationRequirement = determineGraduationRequirement(user);
 		TakenLectureInventory takenLectureInventory = findTakenLectureUseCase.findTakenLectures(
 			user.getId()
@@ -62,7 +62,7 @@ DetailGraduationResult generateTransferChristianDetailGraduationResult(
 		TakenLectureInventory takenLectureInventory
 	) {
 		double christianCreditRequirement = graduationRequirement.getChristianCredit();
-		double totalTakenCredits = (int) calculateChristianTakenCredits(user, takenLectureInventory) +
+		double totalTakenCredits = calculateChristianTakenCredits(user, takenLectureInventory) +
 			user.getTransferCredit().getChristianLecture();
 
 		if (totalTakenCredits > christianCreditRequirement) {

diff --git a/...raduatebe/graduation/domain/service/commonculture/CommonCultureDetailCategoryManager.java b/...raduatebe/graduation/domain/service/commonculture/CommonCultureDetailCategoryManager.java
@@ -8,7 +8,6 @@
 import static com.plzgraduate.myongjigraduatebe.user.domain.model.EnglishLevel.FREE;
 
 import com.plzgraduate.myongjigraduatebe.graduation.domain.model.DetailCategoryResult;
-import com.plzgraduate.myongjigraduatebe.graduation.domain.model.DetailGraduationResult;
 import com.plzgraduate.myongjigraduatebe.lecture.domain.model.CommonCulture;
 import com.plzgraduate.myongjigraduatebe.lecture.domain.model.CommonCultureCategory;
 import com.plzgraduate.myongjigraduatebe.lecture.domain.model.Lecture;

diff --git a/...m/plzgraduate/myongjigraduatebe/graduation/domain/service/major/ElectiveMajorManager.java b/...m/plzgraduate/myongjigraduatebe/graduation/domain/service/major/ElectiveMajorManager.java
@@ -7,7 +7,6 @@
 import java.util.HashSet;
 import java.util.Set;
 
-import com.plzgraduate.myongjigraduatebe.user.domain.model.User;
 import org.springframework.stereotype.Component;
 
 @Component

diff --git a/src/main/java/com/plzgraduate/myongjigraduatebe/parsing/domain/ParsingInformation.java b/src/main/java/com/plzgraduate/myongjigraduatebe/parsing/domain/ParsingInformation.java
@@ -125,7 +125,7 @@ private static ParsingStudentCategoryDto parseStudentCategory(String[] splitText
 		studentCategory = StudentCategory.from(categories);
 		String fourthLine = fourthLineText.substring("편입생 인정학점 - ".length());
 		transferCredit = TransferCredit.from(Arrays.stream(fourthLine.split(","))
-				.map(s -> s.replaceAll("[^0-9]", ""))
+				.map(s -> s.replaceAll("\\D", ""))
 				.collect(Collectors.joining("/")));
 
 		return ParsingStudentCategoryDto.of(

diff --git a/...uate/myongjigraduatebe/graduation/application/service/CalculateGraduationServiceTest.java b/...uate/myongjigraduatebe/graduation/application/service/CalculateGraduationServiceTest.java