Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pick][GraphQL] ConsensusCommitPrologueV3 #18844

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

amnn
Copy link
Member

@amnn amnn commented Jul 29, 2024

Description

Pick PRs to introduce the ConsensusCommitPrologueV3 types into the (soon-to-be legacy) GraphQL release branch, so that it can continue deserializing transaction blocks and effects.

Cherry picks include: #17678, #18816, #18789 (+ a pick to fastcrypto to use reqwest 0.12).

Test plan

sui$ cargo simtest
sui-graphql-rpc$ cargo nextest run
sui-graphql-e2e-tests$ cargo nextest run --features pg_integration

and CI


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

## Description

Pick PRs to introduce the `ConsensusCommitPrologueV3` types into the
(soon-to-be legacy) GraphQL release branch, so that it can continue
deserializing transaction blocks and effects.

## Test plan

```
sui$ cargo simtest
sui-graphql-rpc$ cargo nextest run
sui-graphql-e2e-tests$ cargo nextest run --features pg_integration
```
@amnn amnn requested a review from a team July 29, 2024 17:23
@amnn amnn self-assigned this Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:52pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:52pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:52pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:52pm

@amnn amnn linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amnn

@amnn amnn changed the title [pick #17678, #18816] ConsensusCommitPrologueV3 [pick #17678, #18816, #18789] ConsensusCommitPrologueV3 Jul 30, 2024
@amnn amnn changed the title [pick #17678, #18816, #18789] ConsensusCommitPrologueV3 [pick] ConsensusCommitPrologueV3 Jul 30, 2024
@amnn amnn changed the title [pick] ConsensusCommitPrologueV3 [pick][GraphQL] ConsensusCommitPrologueV3 Jul 30, 2024
Inadvertantly bumped up.
@amnn amnn merged commit f4cef69 into releases/sui-graphql-rpc-v2024.4.0-release Jul 30, 2024
47 of 48 checks passed
@amnn amnn deleted the amnn/pick-17678 branch July 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL block detail query failing after latest mainnet upgrade
3 participants