-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pick][GraphQL] ConsensusCommitPrologueV3 #18844
Merged
amnn
merged 5 commits into
releases/sui-graphql-rpc-v2024.4.0-release
from
amnn/pick-17678
Jul 30, 2024
Merged
[pick][GraphQL] ConsensusCommitPrologueV3 #18844
amnn
merged 5 commits into
releases/sui-graphql-rpc-v2024.4.0-release
from
amnn/pick-17678
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Pick PRs to introduce the `ConsensusCommitPrologueV3` types into the (soon-to-be legacy) GraphQL release branch, so that it can continue deserializing transaction blocks and effects. ## Test plan ``` sui$ cargo simtest sui-graphql-rpc$ cargo nextest run sui-graphql-e2e-tests$ cargo nextest run --features pg_integration ```
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
July 29, 2024 17:23
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
stefan-mysten
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amnn
amnn
changed the title
[pick #17678, #18816] ConsensusCommitPrologueV3
[pick #17678, #18816, #18789] ConsensusCommitPrologueV3
Jul 30, 2024
amnn
changed the title
[pick #17678, #18816, #18789] ConsensusCommitPrologueV3
[pick] ConsensusCommitPrologueV3
Jul 30, 2024
amnn
changed the title
[pick] ConsensusCommitPrologueV3
[pick][GraphQL] ConsensusCommitPrologueV3
Jul 30, 2024
Inadvertantly bumped up.
amnn
merged commit Jul 30, 2024
f4cef69
into
releases/sui-graphql-rpc-v2024.4.0-release
47 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick PRs to introduce the
ConsensusCommitPrologueV3
types into the (soon-to-be legacy) GraphQL release branch, so that it can continue deserializing transaction blocks and effects.Cherry picks include: #17678, #18816, #18789 (+ a pick to
fastcrypto
to usereqwest 0.12
).Test plan
and CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.