sui-types: remove dependency on the move-compiler #20678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Dec 18, 2024
| @@ -770,8 +770,39 @@ impl SuiData for SuiParsedData { | |||
| } | |||
|
|
|||
| fn try_from_package(package: MovePackage) -> Result<Self, anyhow::Error> { | |||
| fn disassemble_modules<'a, I>(modules: I) -> SuiResult<BTreeMap<String, Value>> | |||
There was a problem hiding this comment.
At this point you probably don't need to wrap this in a function
There was a problem hiding this comment.
true...i was just moving code though, i'll fix this before landing
Remove dependency on the move-compiler from the sui-types crate, and move the json-rpc specific functionality to the sui-json-rpc-types crate. In addition remove a few unused dependencies from sui-types.
bmwill
force-pushed
the
remove-compiler-from-sui-types
branch
from
ae1acd5 to
1dc8633
Compare
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on the move-compiler from the sui-types crate, and move the json-rpc specific functionality to the sui-json-rpc-types crate.
In addition remove a few unused dependencies from sui-types.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.