Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong link #20697

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: wrong link #20697

wants to merge 6 commits into from

Conversation

lispking
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?

JSON RPC API change to https://docs.sui.io/sui-api-ref


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 3:42pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 3:42pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 3:42pm

Copy link
Contributor

@ronny-mysten ronny-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments but needs @stefan-mysten 👀 for approval

crates/sui-sdk/src/lib.rs Outdated Show resolved Hide resolved
crates/sui-sdk/src/lib.rs Outdated Show resolved Hide resolved
@lispking lispking temporarily deployed to sui-typescript-aws-kms-test-env December 19, 2024 16:18 — with GitHub Actions Inactive
@stefan-mysten stefan-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 19, 2024 16:37 — with GitHub Actions Inactive
@stefan-mysten
Copy link
Contributor

Awesome, thanks @lispking !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants