-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Timeline Filtering #1535
base: develop
Are you sure you want to change the base?
Conversation
6d887d8
to
7b25a40
Compare
Met with @AaronPlave and @lklyne about remaining tasks this morning. All of the new functionality for advanced filtering of activities is done on this branch and available for testing on our (JPL internal) aerie-test instance. However there is still a bit of design + UI work to be done on integrating this work with the row editor in the Timeline Editor pane. Specifically:
@lklyne will work on a unified UI design for handling these different types in a consistent way + then handoff to @AaronPlave to implement on this branch. |
Implements dynamic activity filtering for the timeline. Closes #1391, closes #973. Potentially addresses #1138.
Changes:
Type
andSubsystem
, globally filter instances byName
,Parameter
(filtered appropriately by the current list of resulting types),Tag
, andScheduling Goal ID
. The user can also add and remove filters (the same as global filters) on specific resulting types. Popover component is draggable and resizable.columnMinSizes
androwMinSizes
props to support min width and height for css grid sectionsTesting (TODO):
TODO:
getEffectiveArguments
every time a user clicks on an activity