Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: package json missing in sdist #23

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Bugfix: package json missing in sdist #23

merged 2 commits into from
Jun 6, 2024

Conversation

akpircher
Copy link
Contributor

Version 1.0.20 is uninstallable with Python because the package.json is missing from the sdist.

This PR ensures the version can be read from the package.json.

@cohansen cohansen self-requested a review June 6, 2024 16:29
cohansen
cohansen approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@cohansen cohansen merged commit fdad4b3 into NASA-AMMOS:develop Jun 6, 2024
1 check passed
@cohansen cohansen mentioned this pull request Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cohansen cohansen cohansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akpircher @cohansen