-
Notifications
You must be signed in to change notification settings - Fork 6
Add all collections and items for public cmip6 data #205
Conversation
6a7eb15
to
15e97b9
Compare
"license": "MIT", | ||
"description": "Predicted year at which the average daily temperature has risen by 2-degrees", | ||
"stac_version": "1.0.0", | ||
"dashboard:is_periodic": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this simply not be here? When do we want to add "dashboard:is_periodic": false
? @anayeaye
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do want dashboard:is_periodic
but it should be true
+ we need to add dashboard:time_density day
. This will tell the summarizer to just return the first and last date and the dashboard UI will create a daily timestep picker. Not sure how nice 30 years of daily data will feel in the UI experience, though, if that's what you mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this - the rasters in question have values which are years rather than, themselves, being indexed by years. In a sense, these two rasters are temporal indices. The rasters themselves are definitely not periodic in the normal sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of COGs set one year apart. Now that I am looking at the crossing year data I see that there is only one COG for each scenario. Not a time series. Sorry about that.
Given that, I think the best thing to do is keep dashboard:is_periodic
false
and adddashboard:time_density
null
.
This will let the dashboard apply the default mosaic xyz logic here but we are definitely pushing the edges of the default cog dashboard display logic here.
This has proven a bit more than the current strategies for ingest can handle. Lambda payload limits mean that the daily ingests, in particular, are vastly too large to be processed all at once. I've had some luck running ingests for a single year (by modifying the regex to capture that detail) but don't think we want to have tens of thousands of lines of json to stare at. I'll be adding a script to this PR which generates JSON sufficient to carry out these ingests but more thought is likely required if we expect this to happen in other datasets (which seems likely) |
I think I am doing what is described in this documentation to work around payload sizes: https://docs.aws.amazon.com/step-functions/latest/dg/avoid-exec-failures.html |
933703e
to
4ee139e
Compare
4ee139e
to
45066ac
Compare
Shouldn't the |
@alukach Our pairing session appears to have landed on a successful strategy: And records are showing up as expected: https://dev-stac.delta-backend.com/collections/nex-gddp-cmip6-monthly-ensemble/items |
62e0aa6
to
1fc23cb
Compare
2d079ee
to
cc5a1c5
Compare
Add support for daily record datetime inference. Add CMIP6 ingests.
cc5a1c5
to
b923736
Compare
e0f9374
to
f02e625
Compare
Difficulties this PR overcomes:
Features: |
It looks like the directory structure in the So the question from here is: should those ingests be removed or should the data it depends on be provided? |
Converted this to draft, as the ingests here are useful but the various bugfixes to make these ingests work will be unnecessary once the airflow branch has been accepted (#257) |
This repo is being sunsetted (#360), so we are closing all open PRs. Please re-open on https://github.com/NASA-IMPACT/veda-data if needed. |
Need to add descriptions and run ingest against the
dev
stack but comments and thoughts are appreciated as I'm not entirely happy with how many collections there are for this one data releaseCloses #204