Add styles to make panel scrollable #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
fix/panel-scroll
branch
2 times, most recently
from
bb8fdc5 to
a5c5bd5
Compare
hanbyul-here
force-pushed
the
fix/panel-scroll
branch
from
a5c5bd5 to
2d0a44d
Compare
nerik
approved these changes
Oct 6, 2023
Co-authored-by: Erik Escoffier <[email protected]>
hanbyul-here
force-pushed
the
fix/panel-scroll
branch
from
d42e21e to
cf8a812
Compare
hanbyul-here
added a commit
that referenced
this pull request
Oct 6, 2023
Follow up of #692 Currently panel body is showing up scrolls even when not needed. This PR fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of : #691
Fixing panel overflowing problem in https://deploy-preview-201--ghg-demo.netlify.app/data-catalog/epa-ch4emission-yeargrid-v2express/explore?projection=equirectangular%7C%7C&basemapid=light&datetime=2020-01-01T00%3A00%3A00.000Z
Wow Scroll is hard. It will be ideal if we can find a way to stick the date widget and make only layers roll, but I am giving up here.. This change basically resurrects what
ShadowScrolldoes for HTML and CSS sans some unnecessary elements for this case.I noticed that the window scroll sometimes pops up if you scroll very fast on the panel area. (Sorry, I cannot reproduce stably enough to grab a screen recording.) this error happens in production environment, too, so this PR doesn't necessarily introduce the error. But with the default (thicker) scroll, the error seems more noticeable.