Fix the bug in writing model output in 2D ensemble grid space #1627 #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good, and it compiles w/o issue. I believe @jvgeiger wants to compare this pull request with an earlier one, so I will hold off on merging. |
|
Question raised during today's LIS Tag Up: Should this change be put into master, or into the public branch first? |
|
Hi @emkemp, |
jvgeiger
pushed a commit
to jvgeiger/LISF
that referenced
this pull request
Nov 26, 2024
…S#1627 See pull request NASA-LIS#1628. (cherry picked from commit 5cae22d)
|
I cherry-picked this commit into the support/lisf-public-7.5 branch. See pull request #1643. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug is related to writing model output in 2D ensemble grid space when the map projection is not lat/lon (equidistant cylindrical) and the vertical level (vlevel) is set to 1. In this part of the code, the variable short_name is used instead of dataEntry%short_name. Since the value of short_name is not properly defined, it pulls a value from memory, which does not match dataEntry%short_name, causing the model to crash.
Resolves #1627
Testcase