Fix for soil texture force-fill exclusion in LDT #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented fix in LDT to address when the Soil texture force exclusion of water points during fill is not set in the ldt.config file, even though STATSGOFAO soil texture and more than 1 surface model type are selected. The default value is set to "false", which causes a mismatch for points north of -60S in STATSGOFAO soil texture and when surface type, e.g., open water, are selected -- and causes LIS run to fail. This is issue is documented in the LISF GitHub issue NASA-LIS#1658. In addition, some additional info has been included in ldt.config.adoc and some additional comment notes for SRTM30 native topo readers for dealing with points south of -60S.
|
The code compiles, and I was able to successfully run and replicate the ldt and lis testcases. I approve of the code revisions as well, so will merge this PR. @karsenau - the lis.config_test file you provided did not have open permissions, but I just used the lis.config_target file, and renamed it to lis.config_test. I only renamed "target" to "test" within the config file, which made it 6 bytes smaller than the original, which is the same difference as your two lis.config files. Anyway, just FYI so you can open permissions to your lis.config_test file for others/posterity. Thanks! |
|
Thanks @dmocko for testing the PR code and use case, and also for mentioning the lis.config_test file permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented fix in LDT to address when the
Soil texture force exclusion of water points during fill is not
set in the ldt.config file, even though STATSGOFAO soil texture
and more than 1 surface model type are selected.
The default value is set to "false", which causes a mismatch for
points north of -60S in STATSGOFAO soil texture and when surface
type, e.g., open water, are selected -- and causes LIS run to fail.
This is issue is documented in the LISF GitHub issue #1658.
In addition, some additional info has been included in ldt.config.adoc
and some additional comment notes for SRTM30 native topo readers
for dealing with points south of -60S.
Testcase
Test case for this PR and fix can be found here:
/discover/nobackup/karsenau/LISF_PR/LDT_SText_ForceOpt_Fix
Tester is able to run the LDT step in:
/discover/nobackup/karsenau/LISF_PR/LDT_SText_ForceOpt_Fix/LDT_Run
with ldt.config_test
Then run a final test of that file in a LIS test case setup, with the lis.config_test file provided. All input files are provided.
MERRA2 input forcing is symlinked in directory: lisdata