Feature/kibana web default tls #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default case is 2048 bits on most systems, 4096 should be more future proof
pdolinic
commented
Sep 5, 2023
widhalmt
requested changes
Sep 6, 2023
There was a problem hiding this comment.
I really like your pull request. This is a major improvement and a step into the right direction.
The only thing I'm asking for is: Leave a note in README.md and/or the docs/ directory about the new default behaviour. So people know that they can just put their certificate and key at the correct place or leave it all to the collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
This PR activates
kibana_tls: trueand sets a default kibana-web-certificate with 10 years of time, if nothing has been set on the paths of