Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-5987: update zap to 2.15.0 #841

Merged
merged 14 commits into from
Jan 6, 2025

Conversation

lapenna-bjss
Copy link
Contributor

@lapenna-bjss lapenna-bjss commented Dec 19, 2024

Summary

This PR resolves issues caused by specific ZAP add-ons. The communityScripts were triggering errors that appeared to be Jython-related, and the wappalyzer add-on incorrectly flagged HSTS as a failure, even though it should only be informational. To address this, the entire packpentester package, which includes wappalyzer, had to be uninstalled, as the tool cannot be uninstalled individually.

Successful Zap scan:
https://dev.azure.com/NHSD-APIM/API%20Platform/_build/results?buildId=275770&view=results

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

github-actions bot commented Jan 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

github-actions bot commented Jan 2, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

github-actions bot commented Jan 3, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

github-actions bot commented Jan 3, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

github-actions bot commented Jan 3, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

Copy link

github-actions bot commented Jan 3, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-5987

@lapenna-bjss lapenna-bjss marked this pull request as ready for review January 3, 2025 14:38
@lapenna-bjss lapenna-bjss merged commit ba9511a into release Jan 6, 2025
7 checks passed
@lapenna-bjss lapenna-bjss deleted the bugfix/ccm-5987-fix-jython-errors branch January 6, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants