-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect any warnings from Jasper #564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test output artifact when spack CI fails * tweak paths for test artifact * tweak * Update Spack.yml * Update Spack.yml * Update Spack.yml
edwardhartnett
requested review from
AlexanderRichert-NOAA and
Hang-Lei-NOAA
September 26, 2023 11:20
edwardhartnett
changed the title
trying to add script-based test
detect any warnings from Jasper
Sep 26, 2023
Hang-Lei-NOAA
approved these changes
Sep 26, 2023
AlexanderRichert-NOAA
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #563
This PR adds a test that will detect jasper warnings. Since jasper inconveniently prints warnings instead of returning error codes, we have to run a jasper-test and then compare the output to the output of the same test, with no jasper warnings.