fix: only try to upload if version number changed #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial fix for #20 which will avoid trying to upload the file to PyPI when version number hasn't changed in setup.py This means we can allow other tests to proceed and get a green tick in PRs without having to constantly bump version number. This will uploads build artifacts so the build is still available for testing, just not from PyPI
marvinmarnold
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Make building and testing better
How
This is a partial fix for #20 which will avoid trying to upload the file to PyPI when version number hasn't changed in setup.py
This means we can allow other tests to proceed and get a green tick in PRs without having to constantly bump version number.
This will upload build artifacts so the build is still available for testing, just not from PyPI
References
#20