-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure p2p protocol matches new Starknet spec #2291
Open
wojciechos
wants to merge
1
commit into
main
Choose a base branch
from
wojciechos/p2p-protocol-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 109 109
Lines 11493 11493
=======================================
Hits 8552 8552
Misses 2277 2277
Partials 664 664 ☔ View full report in Codecov by Sentry. |
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
4 times, most recently
from
November 29, 2024 08:07
ee1b5ee
to
ff56ae3
Compare
kirugan
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
December 3, 2024 12:46
ff56ae3
to
586824e
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
December 12, 2024 09:10
586824e
to
ff3cdc2
Compare
wojciechos
changed the title
Ensure DHT protocol ID matches Starknet spec
Ensure p2p protocol matches new Starknet spec
Dec 12, 2024
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
3 times, most recently
from
December 12, 2024 10:29
426e56d
to
df1ed30
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
17 times, most recently
from
December 16, 2024 09:25
4c6a03d
to
b5190ac
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
December 16, 2024 09:30
b5190ac
to
a2264f6
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
December 16, 2024 09:43
a2264f6
to
fee852d
Compare
AnkushinDaniil
approved these changes
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
2 times, most recently
from
December 16, 2024 13:09
d0f341c
to
f5bdcb6
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
December 17, 2024 03:12
f5bdcb6
to
3377721
Compare
The change ensures that DHT protocol follow latest Starknet specification.
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
December 17, 2024 11:01
3377721
to
54ff331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/starknet/<chain_id>/sync/...
Protocol Path Changes:
Before:
/starknet/headers/0.1.0-rc.0
/starknet/events/0.1.0-rc.0
After:
/starknet/SN_MAIN/sync/headers/0.1.0-rc.0
/starknet/SN_SEPOLIA/sync/events/0.1.0-rc.0