Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure p2p protocol matches new Starknet spec #2291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wojciechos
Copy link
Contributor

@wojciechos wojciechos commented Nov 28, 2024

  • Updated protocol paths to include chain_ID and /sync segment as it is latest starknet p2p spec
  • All protocol paths now follow the format: /starknet/<chain_id>/sync/...
  • Added tests to verify protocol paths

Protocol Path Changes:

Before:

  • /starknet/headers/0.1.0-rc.0
  • /starknet/events/0.1.0-rc.0

After:

  • /starknet/SN_MAIN/sync/headers/0.1.0-rc.0
  • /starknet/SN_SEPOLIA/sync/events/0.1.0-rc.0

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (a9d11d4) to head (54ff331).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2291   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         109      109           
  Lines       11493    11493           
=======================================
  Hits         8552     8552           
  Misses       2277     2277           
  Partials      664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch 4 times, most recently from ee1b5ee to ff56ae3 Compare November 29, 2024 08:07
@kirugan kirugan force-pushed the wojciechos/p2p-protocol-name branch from ff56ae3 to 586824e Compare December 3, 2024 12:46
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch from 586824e to ff3cdc2 Compare December 12, 2024 09:10
@wojciechos wojciechos changed the title Ensure DHT protocol ID matches Starknet spec Ensure p2p protocol matches new Starknet spec Dec 12, 2024
@wojciechos wojciechos marked this pull request as draft December 12, 2024 09:22
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch 3 times, most recently from 426e56d to df1ed30 Compare December 12, 2024 10:29
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch 17 times, most recently from 4c6a03d to b5190ac Compare December 16, 2024 09:25
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch from b5190ac to a2264f6 Compare December 16, 2024 09:30
@wojciechos wojciechos marked this pull request as ready for review December 16, 2024 09:40
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch from a2264f6 to fee852d Compare December 16, 2024 09:43
p2p/starknet/ids.go Show resolved Hide resolved
p2p/starknet/ids.go Outdated Show resolved Hide resolved
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch 2 times, most recently from d0f341c to f5bdcb6 Compare December 16, 2024 13:09
@wojciechos wojciechos requested a review from kirugan December 16, 2024 17:22
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch from f5bdcb6 to 3377721 Compare December 17, 2024 03:12
The change ensures that DHT protocol follow latest Starknet
specification.
@wojciechos wojciechos force-pushed the wojciechos/p2p-protocol-name branch from 3377721 to 54ff331 Compare December 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants