Bootnode Registry

[AnkushinDaniil]

This pull request introduces significant changes to the l1 package, primarily focusing on integrating the IP Address Registry functionality. The most important changes include adding the IP Address Registry ABI, updating the EthSubscriber to handle IP address events, and modifying the Client to subscribe to these events and forward them to the P2P layer.

IP Address Registry Integration:

• l1/abi/ip_address_registry.json: Added the ABI for the IP Address Registry contract, defining functions, errors, and events related to IP address management.
• l1/eth_subscriber.go: Updated the EthSubscriber struct to include the IP Address Registry and its filterer. Added methods to watch for IP address additions and removals, and to get the list of IP addresses. [1] [2] [3]
• l1/l1.go: Added methods to the Client to subscribe to IP address events and forward them to the P2P layer. Modified the Client constructor to accept a channel for forwarding these events. [1] [2] [3] [4] [5] [6] [7] [8]

[codecov]

Codecov Report

Attention: Patch coverage is 85.89744% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (417bb0a) to head (478e8cd).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
l1/eth_subscriber.go	42.85%	15 Missing and 1 partial ⚠️
l1/l1.go	94.05%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2337      +/-   ##
==========================================
+ Coverage   74.49%   74.88%   +0.38%     
==========================================
  Files         110      109       -1     
  Lines       11771    11852      +81     
==========================================
+ Hits         8769     8875     +106     
+ Misses       2324     2291      -33     
- Partials      678      686       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weiihann]

Why is this change needed? The db iterator should give keys which match the prefix, so we don't need to do the prefix check again.

[AnkushinDaniil]

We need to do this, without this prefix check the peer storage won't work. db iterator gives keys that don't match the prefix

[weiihann]

I see the bug now. The NewIterator should create an iterator with lower bound specified. Let me create a PR real quick.

[weiihann]

Please check this:
#2357

[AnkushinDaniil]

Remove prefix check

[weiihann]

I think the name IpAddress may be too vague on what this component actually does. In fact, the address from L1 is not an IP address but rather a multiaddr.

If I understand correctly, there are some peers registered on the L1 smart contract. So we listen to those and adjust the peerstore accordingly. If I'm not wrong, these peers should be bootnodes, so BootnodeRegistry would be more suitable.

Also, not sure if this has been discussed before, who is allowed to add/remove the peers on L1?