Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Add type overload for Push.Permission.request() #244

Closed
wants to merge 3 commits into from
Closed

Add type overload for Push.Permission.request() #244

wants to merge 3 commits into from

Conversation

Jicmou
Copy link

@Jicmou Jicmou commented Feb 19, 2020

Fixes #243

@theLufenk
Copy link
Collaborator

@Jicmou Thank you for this.
There seems to be a test failing. Can you look into it please.

@Nickersoft LGTM. Can be merged.

theLufenk
theLufenk previously approved these changes Feb 19, 2020
@Jicmou
Copy link
Author

Jicmou commented Feb 19, 2020

@theLufenk Thanks for approving.

I can reproduce the failing CI on master. Run the following commands:

npm run test
// passing
npm run build
// builds sucessfully
npm run test
// failing

I ran the first two commands before commiting, as stated in the CONTRIBUTING.md, Travis ran the third.

I could submit my PR without the build though, as index.d.tshas no impact on the build.

Jean-Christophe Maigrot added 2 commits February 19, 2020 11:09
@theLufenk
Copy link
Collaborator

@Nickersoft Over to you.

@theLufenk theLufenk requested a review from Nickersoft February 19, 2020 18:38
@theLufenk
Copy link
Collaborator

nudge @Nickersoft

@Jicmou Jicmou closed this May 16, 2023
@Jicmou Jicmou deleted the type-overload-for-push-permission-request branch May 16, 2023 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types overload missing for Push.Permission.request()
3 participants